Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

playerMin / playerMax should move to settings #160

Open
evoskamp opened this issue Jan 21, 2024 · 2 comments · May be fixed by #162
Open

playerMin / playerMax should move to settings #160

evoskamp opened this issue Jan 21, 2024 · 2 comments · May be fixed by #162
Assignees
@evoskamp
Labels
ACNW ACUS Core Shared issues enhancement New feature or request

Comments

@evoskamp
Copy link
Collaborator

packages/amber/views/Games/GamesDialog.tsx/getDefaultValues # 91

playerMin: configuration.virtual ? 2 : configuration.numberOfSlots === 8 ? 3 : 4,
playerMax: configuration.virtual ? 7 : configuration.numberOfSlots === 8 ? 6 : 10,

Moving to configuration values
@evoskamp evoskamp added enhancement New feature or request ACUS ACNW Core Shared issues labels Jan 21, 2024
@evoskamp evoskamp self-assigned this Jan 21, 2024
@evoskamp
Copy link
Collaborator Author

Adding

playerMin: toNumber(),
playerMax: toNumber(),
playerMinVirtual: toNumber(),
playerMaxVirtual: toNumber(),

@evoskamp
Copy link
Collaborator Author

On second thought, no reason to add playerMinVirtual and playerMaxVirtual: we can always update playerMin and playerMax if we go virtual

evoskamp added a commit that referenced this issue Jan 21, 2024
@evoskamp
Move values into configuration, stop checking # of slots
90c6a4b 
Try and bring ACNW and ACUS together through:
 1. Configuration values
 2.

Added configuration settings:

Copyright holder in footer
 - config.copyright (string)

Used to set range on min and max player in creating games
 - config.playerMin (positive integer)
 - config.playerMax (positive integer)
 - config.minPlayersFloor (positive integer)
 - config.minPlayersCeiling (positive integer)
 - config.maxPlayersFloor (positive integer)
 - config.maxPlayersCeiling (positive integer)

Used by ACUS on its hotel page to allow people to book in its
block of rooms:
 - config.hotelBookingCode (string)
 - config.hotelBookingUrl (string)
 - config.hotelBookingLastdate (date)

Resolves: #155, #158, #160, #161
See also: #159
evoskamp added a commit that referenced this issue Jan 21, 2024
@evoskamp
Remove unneeded variables: use configuration
97acdf9 
Instead of sticking configuration.abbr in local variables of acnw and
acus, which are essentially inverted Boolean flags, check against its
values of 'acus' or 'acnw' directly. It's simpler, clearer, and allows
for adding a third (even if only synthetic) site.

Resolves: #155, #158, #160, #161
See also: #159
@evoskamp evoskamp linked a pull request Jan 21, 2024 that will close this issue
Open
@evoskamp evoskamp linked a pull request Jan 21, 2024 that will close this issue
Move values into configuration settings, stop checking # of slots, use the same magic event ids #162
Open
evoskamp added a commit that referenced this issue Jan 21, 2024
@evoskamp
Move static MDX content to TSX with config settings
98e0787 
Wanted to pick up hotel booking code and link and book by date, as
we change those apparently every year. And also wanted to pick up
the contact email from settings.

Resolves: #163, #155, #158, #160, #161, #159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evoskamp evoskamp

Labels
ACNW ACUS Core Shared issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@evoskamp