Remove unneeded variables: use configuration

Instead of sticking configuration.abbr in local variables of acnw and
acus, which are essentially inverted Boolean flags, check against its
values of 'acus' or 'acnw' directly. It's simpler, clearer, and allows
for adding a third (even if only synthetic) site.

Resolves: #155, #158, #160, #161
See also: #159

Author: evoskamp

packages/amber/components/Footer.tsx

@@ -55,7 +55,6 @@ export const Footer: React.FC = (_props) => {
   const commitDate = DateTime.fromISO(gitHash.date)
   const id = open ? 'simple-popover' : undefined
   const configuration = useConfiguration()
-  const copyrightUrl = configuration.copyright
   return (
     <Box
       component='footer'
@@ -97,7 +96,7 @@ export const Footer: React.FC = (_props) => {
         <Box component='span' sx={{ cursor: 'pointer' }} onClick={handleClick}>
           {hash}
         </Box>{' '}
-        | &copy; {DateTime.fromJSDate(new Date()).year} {copyrightUrl}
+        | &copy; {DateTime.fromJSDate(new Date()).year} {configuration.copyright}
       </Box>
     </Box>
   )

packages/amber/views/GmPage/GmPage.tsx

@@ -128,8 +128,6 @@ const VirtualGmBlurb = () => {
 const GmBlurb = () => {
   const { classes } = useStyles()
   const configuration = useConfiguration()
-  const acus = configuration.abbr === 'acus'
-  const acnw = !acus
   return (
     <>
       <p>
@@ -141,7 +139,7 @@ const GmBlurb = () => {
       </p>
       <ol className={classes.blurb}>
         <li>
-          {acnw && (
+          {configuration.abbr === 'acnw' && (
             <p>
               <strong>Non-Amber Games</strong>: We encourage people to be creative with the diceless format. If you have
               a game that uses a form of the basic Amber DRPG rules but is not set in Amber, you are welcome to post the
@@ -151,7 +149,7 @@ const GmBlurb = () => {
               familiarity and interest in the setting.
             </p>
           )}
-          {acus && (
+          {configuration.abbr === 'acus' && (
             <p>
               <strong>Non-Amber or non-Diceless Games</strong>: We encourage you to be creative and run games that are
               fun for you. We welcome a wide variety of games and settings. If you like to run it, chances are, we'll
@@ -198,7 +196,7 @@ const GmBlurb = () => {
             do.
           </p>
         </li>
-        {acus && (
+        {configuration.abbr === 'acus' && (
           <li>
             <p>
               <strong>Minimum Number of Players</strong>: We no longer accept games that require more than three

packages/amber/views/Payment/Payment.tsx

@@ -34,8 +34,6 @@ export const Payment: React.FC = () => {
   // console.log('Payment', { paymentIntent })
 
   const configuration = useConfiguration()
-  const acus = configuration.abbr === 'acus'
-  const acnw = !acus
 
   return (
     <Page title='Make Payment'>
@@ -57,7 +55,7 @@ export const Payment: React.FC = () => {
       ) : (
         <Loader />
       )}
-      {acnw && balance < 0 ? (
+      {configuration.abbr === 'acnw' && balance < 0 ? (
         <>
           <DialogContentText sx={{ pt: 2 }}>
             Alternatively, write a check for <strong>${Math.max(0 - balance, 0)}</strong> made out to{' '}