Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp normalization #7343

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Mar 14, 2025

Connections

Closes #6719.

Should land after #7140.

Description

Automatically normalizes all timestamps to be in units of nanoseconds instead of the arbitrary unit gpus use.

Testing
Manually so far.

Squash or Rebase?

Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@cwfitzgerald cwfitzgerald force-pushed the cw/timestamp-normalization branch 2 times, most recently from a7e9b1f to 9657e81 Compare March 18, 2025 21:58
@cwfitzgerald cwfitzgerald force-pushed the cw/timestamp-normalization branch from 9657e81 to c0add01 Compare March 24, 2025 22:47
@cwfitzgerald cwfitzgerald force-pushed the cw/timestamp-normalization branch 2 times, most recently from eb9ea7f to ae5724e Compare March 26, 2025 22:38
@cwfitzgerald cwfitzgerald marked this pull request as ready for review March 26, 2025 22:38
@cwfitzgerald cwfitzgerald requested a review from a team as a code owner March 26, 2025 22:38
@teoxoy teoxoy self-assigned this Mar 27, 2025
@cwfitzgerald cwfitzgerald force-pushed the cw/timestamp-normalization branch from ae5724e to f338e2a Compare April 2, 2025 23:28
@cwfitzgerald cwfitzgerald requested a review from teoxoy April 2, 2025 23:28
@cwfitzgerald cwfitzgerald merged commit c344bec into gfx-rs:trunk Apr 3, 2025
37 checks passed
@cwfitzgerald cwfitzgerald deleted the cw/timestamp-normalization branch April 3, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebGPU requires timestamps in nanoseconds
3 participants