-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timestamp normalization #7343
Merged
cwfitzgerald
merged 2 commits into
gfx-rs:trunk
from
cwfitzgerald:cw/timestamp-normalization
Apr 3, 2025
Merged
Timestamp normalization #7343
cwfitzgerald
merged 2 commits into
gfx-rs:trunk
from
cwfitzgerald:cw/timestamp-normalization
Apr 3, 2025
+1,215
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7e9b1f
to
9657e81
Compare
9657e81
to
c0add01
Compare
cwfitzgerald
commented
Mar 26, 2025
cwfitzgerald
commented
Mar 26, 2025
cwfitzgerald
commented
Mar 26, 2025
eb9ea7f
to
ae5724e
Compare
teoxoy
requested changes
Mar 27, 2025
ae5724e
to
f338e2a
Compare
teoxoy
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
Closes #6719.
Should land after #7140.
Description
Automatically normalizes all timestamps to be in units of nanoseconds instead of the arbitrary unit gpus use.
Testing
Manually so far.
Squash or Rebase?
Squash
Checklist
cargo fmt
.taplo format
.cargo clippy
. If applicable, add:--target wasm32-unknown-unknown
cargo xtask test
to run tests.CHANGELOG.md
entry.