Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 #233

Merged
merged 4 commits into from
Feb 11, 2025
Merged

V2 #233

merged 4 commits into from
Feb 11, 2025

Conversation

paul-paliychuk
Copy link
Contributor

@paul-paliychuk paul-paliychuk commented Feb 11, 2025

Important

Add methods to handle user nodes and episode deletion, update version to 2.4.0, and enhance documentation.

  • Behavior:
    • Add get_node() method to UserClient and AsyncUserClient in user/client.py to retrieve user nodes.
    • Add delete() method to EpisodeClient and AsyncEpisodeClient in graph/episode/client.py to delete episodes by UUID.
  • Models:
    • Add UserNodeResponse model in types/user_node_response.py.
  • Versioning:
    • Update version to 2.4.0 in pyproject.toml and client_wrapper.py.
  • Documentation:
    • Update reference.md with new methods get_node() and delete() for user and episode clients respectively.

This description was created by Ellipsis for 2eec271. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2eec271 in 1 minute and 55 seconds

More details
  • Looked at 524 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 10 drafted comments based on config settings.
1. src/zep_cloud/user/client.py:218
  • Draft comment:
    Docstring in 'delete' describes 'delete user by id'. For consistency and clarity, consider capitalizing ("Delete user by ID").
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. src/zep_cloud/user/client.py:316
  • Draft comment:
    Consider refactoring repeated error handling blocks to reduce duplication (e.g. status code checks and JSON parsing).
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. src/zep_cloud/types/user_node_response.py:18
  • Draft comment:
    Docstrings and function names are auto-generated and look consistent. No issues found.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. src/zep_cloud/core/client_wrapper.py:20
  • Draft comment:
    Version in header 'X-Fern-SDK-Version' is updated to 2.4.0 – ensure this aligns with documentation.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
5. src/zep_cloud/graph/episode/client.py:217
  • Draft comment:
    Error handling for DELETE method includes explicit handling for 404. This is clear; consider adding comment documenting expected error scenarios.
  • Reason this comment was not posted:
    Confidence changes required: 30% <= threshold 50%
    None
6. src/zep_cloud/user/client.py:96
  • Draft comment:
    There is a repeated pattern of calling _response.json() in both success and error branches. Consider caching the result in a variable to avoid redundant calls and potential issues if the response stream is consumed.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
7. src/zep_cloud/user/client.py:112
  • Draft comment:
    A similar error-handling pattern is repeated across methods (e.g., list_ordered, get, delete, update, get_facts, etc.). Consider refactoring the response parsing and error-handling logic into a shared helper to reduce duplication.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
8. src/zep_cloud/user/client.py:23
  • Draft comment:
    The global constant 'OMIT' is used as a default value for optional parameters. Consider adding an inline comment or documentation note to clarify its purpose for future maintainers.
  • Reason this comment was not posted:
    Comment was on unchanged code.
9. src/zep_cloud/user/client.py:415
  • Draft comment:
    Docstrings include examples that use 'asyncio.run()'. Note that in environments with an existing running event loop (e.g., notebooks), this may cause issues. Consider noting alternative usage patterns for async calls.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50%
    None
10. src/zep_cloud/user/client.py:349
  • Draft comment:
    The error-handling for API responses (checking status codes and raising specific errors) is consistent. Ensure that any additional status codes or edge cases defined in the API spec are handled appropriately, such as potential 401 or 403 errors.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_5wSfBPMWwYTkuUqU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@paul-paliychuk paul-paliychuk merged commit 91a4589 into main Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant