Skip to content

ref: use a better hashing algorithm for test bucketing #88914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

ref: use a better hashing algorithm for test bucketing #88914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/sentry/testutils/pytest/sentry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import sys
import time
from datetime import datetime
from hashlib import md5
from hashlib import sha256
from typing import TypeVar
from unittest import mock

Expand Down Expand Up @@ -415,7 +415,7 @@ def pytest_collection_modifyitems(config: pytest.Config, items: list[pytest.Item
if grouping_strategy == "scope"
else item.nodeid.encode()
)
item_to_group = int(md5(to_hash).hexdigest(), 16)
item_to_group = int(sha256(to_hash).hexdigest(), 16)

# Split tests in different groups
group_num = item_to_group % total_groups
Expand Down
Loading