Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(replays): Update validators to explicitly accept projectSlug #88906

Merged
merged 3 commits into from
Apr 7, 2025
Merged

chore(replays): Update validators to explicitly accept projectSlug #88906

merged 3 commits into from
Apr 7, 2025

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Apr 7, 2025 •
edited
Loading

We allow the project slug to be specified as well as the project id. This pull updates the OpenAPI docs to reflect that.

Ref: #88776

@cmanallen cmanallen requested a review from a team as a code owner April 7, 2025 13:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2025
billyvg
billyvg approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this more than a docs change?

@cmanallen cmanallen changed the title docs(replays): Fix endpoint documentation chore(replays): Update validators to explicitly accept projectSlug Apr 7, 2025
@cmanallen
Copy link
Member Author

@billyvg You're right. I added the validators later which makes this a code change. Updated the title.

@cmanallen cmanallen merged commit da46d4c into master Apr 7, 2025
48 of 49 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-fix-documentation branch April 7, 2025 16:28
andrewshie-sentry pushed a commit that referenced this pull request Apr 8, 2025
@cmanallen @andrewshie-sentry
chore(replays): Update validators to explicitly accept projectSlug (#…
c3e4cd8 
…88906)

We allow the project slug to be specified as well as the project id.
This pull updates the OpenAPI docs to reflect that.

Ref: #88776
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmanallen @billyvg