feat(assemble): Improve error messages for assemble endpoint #88905
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
iambriccardo
commented
Apr 7, 2025
| return Response({"error": str(e).splitlines()[0]}, status=400) | ||
| # Get the field from the path if available | ||
| field = None | ||
| if e.path: |
There was a problem hiding this comment.
This field contains a queue of the fields inside the schema that are matched.
| path = list(e.path) | ||
| field = path.pop(0) if path else None | ||
|
|
||
| return Response({"error": error_messages.get(field, e.message)}, status=400) |
There was a problem hiding this comment.
If 'field' is not a string (for example, if it's an integer from an array index), the lookup in error_messages may fail unexpectedly. Consider explicitly casting 'field' to a string for consistency: error_messages.get(str(field), e.message).
Suggested change
| return Response({"error": error_messages.get(field, e.message)}, status=400) | |
| return Response({"error": error_messages.get(str(field), e.message)}, status=400) |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the error messages for the assemble endpoint.
Closes: #88068