perf(replays): Remove flush on every event #88903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
This doesn't seem like a strong reason to revert. Is the perf overhead significant right now? we must revert? |
|
@bruno-garcia I was pinged by fillipo on friday. waiting to hear back from him. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're flushing on every event. We should flush rarely. Ideally, we do this once when the consumer commits but I need time to write and validate. In the meantime, this PR will revert us to the old behavior (no flushing) which is technically a bug since data can be lost. Since we had this bug for a very long time without complaint its likely that the bug is either rare or common but not noticeable.