feat(onboarding): Add profiling onboarding for ruby & co #88888
Merged
+65
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
|
@priscilawebdev since it is 3 times the same content, it could be in one util. |
|
@ArthurKnaus I thought about it, and for future cases like this, I’d like to avoid creating a separate file for each platform in the utils folder just to render the profiling onboarding or something similar. I was thinking we could export the function and reuse it where needed instead, keeping things co-located. What do you think? |
ArthurKnaus
reviewed
Apr 8, 2025
| @@ -10,6 +10,68 @@ import {t, tct} from 'sentry/locale'; | |||
|
|
|||
| type Params = DocsParams; | |||
|
|
|||
| export function getProfilingOnboarding(): OnboardingConfig { | |||
There was a problem hiding this comment.
nit: could be a simple constant
Suggested change
| export function getProfilingOnboarding(): OnboardingConfig { | |
| export function profilingOnboarding = { |
ArthurKnaus
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add specific profiling docs for ruby, rack, and rails.
Notes:
Added docs just for Stackprof as it is what we display in our main onboarding. This made me wonder if we should provide a way to switch between Stackprof and Vernier.
Also, in the main onboarding we guide users to install
gem "sentry-rails"while in the docs, we do not do the same. What is correct? cc @sl0thentr0pycloses TET-256