Add support for files up to 4G #88882
Open
+158
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Swatinem
force-pushed
the
swatinem/4g-files
branch
from
90906a9 to
c604e81
Compare
|
This PR has a migration; here is the generated SQL for --
-- Alter field size on controlfile
--
ALTER TABLE "sentry_controlfile" DROP CONSTRAINT "sentry_controlfile_size_check";
--
-- Alter field size on controlfileblob
--
ALTER TABLE "sentry_controlfileblob" DROP CONSTRAINT "sentry_controlfileblob_size_check";
--
-- Alter field offset on controlfileblobindex
--
ALTER TABLE "sentry_controlfileblobindex" DROP CONSTRAINT "sentry_controlfileblobindex_offset_check";
--
-- Alter field size on file
--
ALTER TABLE "sentry_file" DROP CONSTRAINT "sentry_file_size_check";
--
-- Alter field size on fileblob
--
ALTER TABLE "sentry_fileblob" DROP CONSTRAINT "sentry_fileblob_size_check";
--
-- Alter field offset on fileblobindex
--
ALTER TABLE "sentry_fileblobindex" DROP CONSTRAINT "sentry_fileblobindex_offset_check"; |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This is achieved by introducing a new `WrappingU32IntegerField` DB type. This new type implements full unsigned `u32` numbers by wrapping them around and storing them as signed `i32` values in the DB. In contrast to the existing `BoundedPositiveIntegerField`, this is not adding a DB `CHECK` constraint rejecting negative numbers. A migration was also added to change the various `size` and `offset` fields of the `File/Blob/Index` models to switch to this new type, which essentially drops the `CHECK` constraint from the DB, and thus allows negative DB values which will then be converted to a signed type on the client side.
Swatinem
force-pushed
the
swatinem/4g-files
branch
from
b6db0ef to
b4d2ed7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved by introducing a new
WrappingU32IntegerFieldDB type.This new type implements full unsigned
u32numbers by wrapping them around and storing them as signedi32values in the DB.In contrast to the existing
BoundedPositiveIntegerField, this is not adding a DBCHECKconstraint rejecting negative numbers. A migration was also added to change the varioussizeandoffsetfields of theFile/Blob/Indexmodels to switch to this new type, which essentially drops theCHECKconstraint from the DB, and thus allows negative DB values which will then be converted to a signed type on the client side.Fixes https://github.com/getsentry/team-ingest/issues/690