Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(issues): Remove redundant trace link #86160

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mrduncan
Copy link
Member

@mrduncan mrduncan commented Mar 1, 2025

We already have a link in the upper-right, this one feels pretty redundant.

Before:
Screenshot 2025-02-28 at 4 02 16 PM

After:
Screenshot 2025-02-28 at 4 01 50 PM

Non-streamline version is a separate component, no changes there:
Screenshot 2025-02-28 at 4 06 04 PM

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 1, 2025
@doralchan doralchan self-requested a review March 1, 2025 00:08
Copy link
Contributor

@doralchan doralchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was on my TODO list so thanks for takin care of that!

Copy link

codecov bot commented Mar 1, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9630 2 9628 4
View the top 2 failed test(s) by shortest run time
AutofixRootCause can view a relevant code snippet
Stack Traces | 0.098s run time
TestingLibraryElementError: Unable to find an element with the text: This is the code snippet and analysis of a root cause.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at Object.getElementError (.../sentry/sentry/node_modules/@.../dom/dist/config.js:37:19)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:76:38
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:52:17
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:95:19
    at Object.<anonymous> (.../events/autofix/autofixRootCause.spec.tsx:32:40)
EventTraceView still renders trace link for performance issues
Stack Traces | 1.03s run time
Error: Unable to find role="link" and name "View Full Trace"

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../interfaces/performance/eventTraceView.spec.tsx:167:46)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants