fix(api): better error message return to the client #86155
+19
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
snigdhas
approved these changes
Feb 28, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #86155 +/- ##
===========================================
+ Coverage 46.68% 87.88% +41.19%
===========================================
Files 9698 9712 +14
Lines 549884 550541 +657
Branches 21441 21441
===========================================
+ Hits 256731 483829 +227098
+ Misses 292773 66332 -226441
Partials 380 380 |
|
i've changed the PR to not return the message from snuba directly. there is too much internal information, and we should instead construct a message specifically for customers telling them what quota limit they went over, and how long until they can query again. |
wedamija
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are many types of snuba rate limits now, and snuba returns them from their API. let's pass them on to the client so at least its more transparent as to what's going on. right now, no matter what, we tell the user to try again in 1 second, while some snuba rate limits operate on windows of 10 minutes, etc.
Also capture the exception so we can better debug this.