Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(uptime): Remove unique constraint and migrated column from UptimeSubscription #86081

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

wedamija
Copy link
Member

These are no longer used, and so can be removed.

@wedamija wedamija requested review from a team as code owners February 27, 2025 23:14
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 27, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/uptime/migrations/0027_remove_migrated_and_unique_constraint.py ()

--
-- Remove constraint uptime_uptimesubscription_unique_subscription_check_4 from model uptimesubscription
--
DROP INDEX CONCURRENTLY IF EXISTS "uptime_uptimesubscription_unique_subscription_check_4";
--
-- Moved uptimesubscription.migrated field to pending deletion state
--
-- (no-op)

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #86081       +/-   ##
===========================================
+ Coverage   46.68%   87.88%   +41.19%     
===========================================
  Files        9696     9712       +16     
  Lines      549830   550491      +661     
  Branches    21441    21441               
===========================================
+ Hits       256702   483775   +227073     
+ Misses     292749    66337   -226412     
  Partials      379      379               

@wedamija wedamija force-pushed the danf/uptime-cleanup-migration-code branch from 64bf0df to 2505b16 Compare February 28, 2025 18:14
Base automatically changed from danf/uptime-cleanup-migration-code to master February 28, 2025 18:42
…imeSubscription`

These are no longer used, and so can be removed.
@wedamija wedamija force-pushed the danf/uptime-cleanup-unique-constraint-migration branch from 5ae6b77 to 88e5b9e Compare February 28, 2025 19:11
@wedamija wedamija enabled auto-merge (squash) February 28, 2025 20:24
@wedamija wedamija merged commit 0bda995 into master Feb 28, 2025
49 checks passed
@wedamija wedamija deleted the danf/uptime-cleanup-unique-constraint-migration branch February 28, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants