fix(member-invite): use hook to get default org roles #85994
Merged
+86
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ameliahsu
force-pushed
the
mia/member-invite/org-roles
branch
from
8efb15e to
41e1a77
Compare
| /** | ||
| * Get list of organization roles | ||
| */ | ||
| 'member-invite-modal:organization-roles': getOrgRoles, |
There was a problem hiding this comment.
uh general js Q, why is one hook do () => function vs just function obj ? Is there a difference they would both be functions ❓
There was a problem hiding this comment.
There are differences but I don't think we really care about them in this case? I am not sure
https://www.freecodecamp.org/news/the-difference-between-arrow-functions-and-normal-functions/
iamrajjoshi
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We determine the role options for the member invite modal using the inviter's member details. However, if a superuser is using the invite modal, then the inviter is not a member and the organization member details endpoint will 404. In this case, we use a default list of org roles to populate the role dropdown in the modal.
We should use a hook to get the default list of org roles so that we can include a Billing role, and only show the Admin role when the org is not on a business or enterprise plan.