Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: code is non-null #85871

Merged
merged 1 commit into from
Feb 25, 2025
Merged

ref: code is non-null #85871

merged 1 commit into from
Feb 25, 2025

Conversation

asottile-sentry
Copy link
Member

fix passing code around for exchange_token

fix passing code around for exchange_token
@asottile-sentry asottile-sentry requested review from a team February 25, 2025 17:51
@asottile-sentry asottile-sentry requested review from a team as code owners February 25, 2025 17:51
@asottile-sentry asottile-sentry enabled auto-merge (squash) February 25, 2025 17:51
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Feb 25, 2025
@asottile-sentry asottile-sentry merged commit 73b5a30 into master Feb 25, 2025
50 checks passed
@asottile-sentry asottile-sentry deleted the asottile-code-non-null branch February 25, 2025 18:33
Copy link

sentry-io bot commented Feb 25, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ MultiValueDictKeyError: 'code' /extensions/{provider_id}/setup/ View Issue

Did you find this useful? React with a 👍 or 👎

@asottile-sentry asottile-sentry added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Feb 25, 2025
@getsentry-bot
Copy link
Contributor

PR reverted: e9e0109

getsentry-bot added a commit that referenced this pull request Feb 25, 2025
This reverts commit 73b5a30.

Co-authored-by: asottile-sentry <[email protected]>
@asottile-sentry
Copy link
Member Author

wow actually useful for once -- looks like this can be called with error= and not code= -- so I need an additional null check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert Add to a merged PR to revert it (skips CI)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants