-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update clickhouse version 24.3.5.47 [DO NOT MERGE...YET] #81376
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81376 +/- ##
==========================================
+ Coverage 78.48% 80.69% +2.21%
==========================================
Files 7215 7316 +101
Lines 319793 322989 +3196
Branches 44034 20727 -23307
==========================================
+ Hits 250996 260648 +9652
+ Misses 62404 61948 -456
+ Partials 6393 393 -6000 |
I see many logs with: |
<profiles> | ||
<!-- Default settings. --> | ||
<default> | ||
<allow_experimental_analyzer>0</allow_experimental_analyzer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems like a lot of the failing tests could be because this setting is enabled by default in the newer versions. I think maybe we could be overwriting these settings in users.d
directory but wasn't sure if that was for different profiles and I wanted to set this as the default
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you add the label "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
My sentry work with clickhouse 24.3 |
Looks like |
devservices was updated to have the source of the clickhouse version be in snuba, so from now on if we want to test new clickhouse versions in sentry CI we need two things:
I'm closing this PR since changing the clickhouse version in sentry won't be reflected in CI |
We added clickhouse version
24.3.5.47
to snuba CI in getsentry/snuba#6246.This PR is to test for any bugs in Sentry CI related to this new version. We will start upgrading production clusters in the near future, but this PR should not be merged until that work is done.