Skip to content

Commit

Permalink
chore(uptime): Drop migrated column from UptimeSubscription (#86082)
Browse files Browse the repository at this point in the history
Actually remove the column

<!-- Describe your PR here. -->
  • Loading branch information
wedamija authored Mar 1, 2025
1 parent e03c15a commit a1d4314
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 1 deletion.
2 changes: 1 addition & 1 deletion migrations_lockfile.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,6 @@ social_auth: 0002_default_auto_field

tempest: 0002_make_message_type_nullable

uptime: 0027_remove_migrated_and_unique_constraint
uptime: 0028_drop_migrated_column

workflow_engine: 0032_remove_data_source_query_id
33 changes: 33 additions & 0 deletions src/sentry/uptime/migrations/0028_drop_migrated_column.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
# Generated by Django 5.1.5 on 2025-02-27 23:17

from sentry.new_migrations.migrations import CheckedMigration
from sentry.new_migrations.monkey.fields import SafeRemoveField
from sentry.new_migrations.monkey.state import DeletionAction


class Migration(CheckedMigration):
# This flag is used to mark that a migration shouldn't be automatically run in production.
# This should only be used for operations where it's safe to run the migration after your
# code has deployed. So this should not be used for most operations that alter the schema
# of a table.
# Here are some things that make sense to mark as post deployment:
# - Large data migrations. Typically we want these to be run manually so that they can be
# monitored and not block the deploy for a long period of time while they run.
# - Adding indexes to large tables. Since this can take a long time, we'd generally prefer to
# run this outside deployments so that we don't block them. Note that while adding an index
# is a schema change, it's completely safe to run the operation after the code has deployed.
# Once deployed, run these manually via: https://develop.sentry.dev/database-migrations/#migration-deployment

is_post_deployment = False

dependencies = [
("uptime", "0027_remove_migrated_and_unique_constraint"),
]

operations = [
SafeRemoveField(
model_name="uptimesubscription",
name="migrated",
deletion_action=DeletionAction.DELETE,
),
]

0 comments on commit a1d4314

Please sign in to comment.