fix(aci): handle cases found in dry run (#85600)

src/sentry/workflow_engine/migration_helpers/issue_alert_conditions.py

@@ -134,7 +134,7 @@ def create_new_high_priority_issue_data_condition(
 @data_condition_translator_registry.register(LevelCondition.id)
 @data_condition_translator_registry.register(LevelFilter.id)
 def create_level_data_condition(data: dict[str, Any], dcg: DataConditionGroup) -> DataCondition:
-    comparison = {"match": data["match"], "level": data["level"]}
+    comparison = {"match": data["match"], "level": int(data["level"])}
 
     return DataCondition(
         type=Condition.LEVEL,
@@ -204,7 +204,7 @@ def create_issue_category_data_condition(
     data: dict[str, Any], dcg: DataConditionGroup
 ) -> DataCondition:
     comparison = {
-        "value": data["value"],
+        "value": int(data["value"]),
     }
 
     return DataCondition(

src/sentry/workflow_engine/migration_helpers/issue_alert_migration.py

@@ -1,6 +1,7 @@
 import logging
 from typing import Any
 
+from sentry.constants import ObjectStatus
 from sentry.grouping.grouptype import ErrorGroupType
 from sentry.models.rule import Rule
 from sentry.models.rulesnooze import RuleSnooze
@@ -56,11 +57,11 @@ def run(self) -> None:
         workflow = self._create_workflow_and_lookup(
             conditions=conditions,
             filters=filters,
-            action_match=self.data["action_match"],
+            action_match=self.data.get("action_match", Rule.DEFAULT_CONDITION_MATCH),
             detector=error_detector,
         )
         if_dcg = self._create_if_dcg(
-            filter_match=self.data.get("filter_match", "all"),
+            filter_match=self.data.get("filter_match", Rule.DEFAULT_FILTER_MATCH),
             workflow=workflow,
             conditions=conditions,
             filters=filters,
@@ -162,6 +163,8 @@ def _create_workflow_and_lookup(
         rule_snooze = RuleSnooze.objects.filter(rule=self.rule, user_id=None).first()
         if rule_snooze and rule_snooze.until is None:
             enabled = False
+        if self.rule.status == ObjectStatus.DISABLED:
+            enabled = False
 
         config = {"frequency": self.rule.data.get("frequency") or Workflow.DEFAULT_FREQUENCY}
         kwargs = {

tests/sentry/workflow_engine/handlers/condition/test_issue_category_handler.py

@@ -14,7 +14,7 @@ class TestIssueCategoryCondition(ConditionTestCase):
     condition = Condition.ISSUE_CATEGORY
     payload = {
         "id": IssueCategoryFilter.id,
-        "value": 1,
+        "value": "1",
     }
 
     def setUp(self):

tests/sentry/workflow_engine/handlers/condition/test_level_handler.py

@@ -14,7 +14,7 @@ class TestLevelCondition(ConditionTestCase):
     payload = {
         "id": LevelCondition.id,
         "match": MatchType.EQUAL,
-        "level": 20,
+        "level": "20",
     }
 
     def setup_group_event_and_job(self):

tests/sentry/workflow_engine/migration_helpers/test_migrate_rule.py

@@ -3,6 +3,7 @@
 import pytest
 from jsonschema.exceptions import ValidationError
 
+from sentry.constants import ObjectStatus
 from sentry.grouping.grouptype import ErrorGroupType
 from sentry.models.rulesnooze import RuleSnooze
 from sentry.rules.age import AgeComparisonType
@@ -406,7 +407,9 @@ def assert_nothing_migrated(self, issue_alert):
         assert DataCondition.objects.all().count() == 0
         assert Action.objects.all().count() == 0
 
-    def assert_issue_alert_migrated(self, issue_alert, is_enabled=True):
+    def assert_issue_alert_migrated(
+        self, issue_alert, is_enabled=True, logic_type=DataConditionGroup.Type.ANY_SHORT_CIRCUIT
+    ):
         issue_alert_workflow = AlertRuleWorkflow.objects.get(rule=issue_alert)
         issue_alert_detector = AlertRuleDetector.objects.get(rule=issue_alert)
 
@@ -431,7 +434,7 @@ def assert_issue_alert_migrated(self, issue_alert, is_enabled=True):
         assert detector_workflow.workflow == workflow
 
         assert workflow.when_condition_group
-        assert workflow.when_condition_group.logic_type == DataConditionGroup.Type.ANY_SHORT_CIRCUIT
+        assert workflow.when_condition_group.logic_type == logic_type
         conditions = DataCondition.objects.filter(condition_group=workflow.when_condition_group)
         assert conditions.count() == 2
         assert conditions.filter(
@@ -442,7 +445,7 @@ def assert_issue_alert_migrated(self, issue_alert, is_enabled=True):
         ).exists()
 
         if_dcg = WorkflowDataConditionGroup.objects.get(workflow=workflow).condition_group
-        assert if_dcg.logic_type == DataConditionGroup.Type.ANY_SHORT_CIRCUIT
+        assert if_dcg.logic_type == logic_type
         filters = DataCondition.objects.filter(condition_group=if_dcg)
         assert filters.count() == 1
         assert filters.filter(
@@ -464,6 +467,28 @@ def test_run(self):
         action = dcg_actions.action
         assert action.type == Action.Type.SLACK
 
+    def test_run__missing_matches(self):
+        data = self.issue_alert.data
+        del data["action_match"]
+        del data["filter_match"]
+        IssueAlertMigrator(self.issue_alert, self.user.id).run()
+
+        self.assert_issue_alert_migrated(self.issue_alert, logic_type=DataConditionGroup.Type.ALL)
+
+        dcg_actions = DataConditionGroupAction.objects.all()[0]
+        action = dcg_actions.action
+        assert action.type == Action.Type.SLACK
+
+    def test_run__disabled_rule(self):
+        self.issue_alert.update(status=ObjectStatus.DISABLED)
+        IssueAlertMigrator(self.issue_alert, self.user.id).run()
+
+        self.assert_issue_alert_migrated(self.issue_alert, is_enabled=False)
+
+        dcg_actions = DataConditionGroupAction.objects.all()[0]
+        action = dcg_actions.action
+        assert action.type == Action.Type.SLACK
+
     def test_run__snoozed_rule(self):
         RuleSnooze.objects.create(rule=self.issue_alert)
         IssueAlertMigrator(self.issue_alert, self.user.id).run()