Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Make getDataFromUri Public #4638

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Make getDataFromUri Public #4638

wants to merge 4 commits into from
+20 −3

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Mar 10, 2025 •
edited
Loading

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Make getDataFromUri Public

💡 Motivation and Context

Fixes: #4635

💚 How did you test it?

CI, Manual

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b24da20

@antonis antonis marked this pull request as ready for review March 10, 2025 07:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 461.45 ms 468.47 ms 7.02 ms
Size 17.75 MiB 20.12 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
8e80789 430.76 ms 431.45 ms 0.69 ms
cdf2bdf 448.42 ms 443.42 ms -5.00 ms
d053743 429.96 ms 444.20 ms 14.24 ms
946a600 384.53 ms 366.65 ms -17.88 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
5f03ae9 444.88 ms 448.89 ms 4.01 ms
ae7b03d 428.82 ms 412.33 ms -16.49 ms
fe13591 478.92 ms 480.84 ms 1.92 ms
60d7316 418.46 ms 414.12 ms -4.34 ms

App size

Revision Plain With Sentry Diff
8e80789 17.74 MiB 20.10 MiB 2.36 MiB
cdf2bdf 17.74 MiB 20.10 MiB 2.36 MiB
d053743 17.75 MiB 20.12 MiB 2.37 MiB
946a600 17.74 MiB 20.09 MiB 2.35 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
5f03ae9 17.75 MiB 20.11 MiB 2.36 MiB
ae7b03d 17.75 MiB 20.11 MiB 2.37 MiB
fe13591 17.74 MiB 20.07 MiB 2.34 MiB
60d7316 17.75 MiB 20.11 MiB 2.36 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 365.85 ms 365.68 ms -0.17 ms
Size 7.15 MiB 8.39 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d16beca+dirty 389.49 ms 423.86 ms 34.37 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms
2dc8f22+dirty 373.17 ms 400.42 ms 27.25 ms
cdf2bdf+dirty 391.69 ms 461.14 ms 69.45 ms
686b3bc+dirty 363.48 ms 356.17 ms -7.31 ms
1c9e040+dirty 372.30 ms 417.80 ms 45.50 ms
13f280b+dirty 376.13 ms 406.41 ms 30.28 ms
13b68d9+dirty 372.54 ms 388.85 ms 16.31 ms
4a6664f+dirty 357.02 ms 394.91 ms 37.89 ms
5fe8312+dirty 389.98 ms 421.46 ms 31.48 ms

App size

Revision Plain With Sentry Diff
d16beca+dirty 7.15 MiB 8.37 MiB 1.22 MiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB
2dc8f22+dirty 7.15 MiB 8.38 MiB 1.23 MiB
cdf2bdf+dirty 7.15 MiB 8.38 MiB 1.23 MiB
686b3bc+dirty 7.15 MiB 8.38 MiB 1.23 MiB
1c9e040+dirty 7.15 MiB 8.38 MiB 1.23 MiB
13f280b+dirty 7.15 MiB 8.35 MiB 1.20 MiB
13b68d9+dirty 7.15 MiB 8.38 MiB 1.23 MiB
4a6664f+dirty 7.15 MiB 8.22 MiB 1.07 MiB
5fe8312+dirty 7.15 MiB 8.38 MiB 1.23 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.64 ms 1233.79 ms 10.15 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms
34aba08+dirty 1276.78 ms 1308.52 ms 31.74 ms
8bda0cc+dirty 1221.90 ms 1208.11 ms -13.79 ms
ad6c299+dirty 1244.76 ms 1260.10 ms 15.34 ms
60d7316+dirty 1219.13 ms 1221.74 ms 2.61 ms
d997097+dirty 1231.90 ms 1236.80 ms 4.90 ms
0d3e677+dirty 1214.39 ms 1225.70 ms 11.31 ms
7143e6f+dirty 1237.04 ms 1233.88 ms -3.16 ms
7e87527+dirty 1209.85 ms 1216.31 ms 6.46 ms
c639edf+dirty 1236.18 ms 1235.04 ms -1.14 ms

App size

Revision Plain With Sentry Diff
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB
34aba08+dirty 2.36 MiB 2.85 MiB 495.32 KiB
8bda0cc+dirty 2.63 MiB 3.70 MiB 1.06 MiB
ad6c299+dirty 2.36 MiB 2.84 MiB 488.85 KiB
60d7316+dirty 2.63 MiB 3.74 MiB 1.11 MiB
d997097+dirty 2.63 MiB 3.70 MiB 1.06 MiB
0d3e677+dirty 2.36 MiB 3.10 MiB 753.12 KiB
7143e6f+dirty 2.63 MiB 3.70 MiB 1.06 MiB
7e87527+dirty 2.63 MiB 3.69 MiB 1.05 MiB
c639edf+dirty 2.36 MiB 3.08 MiB 736.63 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 10, 2025 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.27 ms 1213.29 ms -1.97 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms
34aba08+dirty 1268.58 ms 1276.80 ms 8.22 ms
8bda0cc+dirty 1217.90 ms 1223.02 ms 5.12 ms
ad6c299+dirty 1248.50 ms 1248.88 ms 0.38 ms
60d7316+dirty 1224.33 ms 1231.29 ms 6.96 ms
d997097+dirty 1223.29 ms 1229.76 ms 6.46 ms
0d3e677+dirty 1239.02 ms 1241.22 ms 2.20 ms
7143e6f+dirty 1228.29 ms 1229.02 ms 0.73 ms
7e87527+dirty 1223.83 ms 1222.90 ms -0.94 ms
c639edf+dirty 1223.63 ms 1227.98 ms 4.35 ms

App size

Revision Plain With Sentry Diff
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB
34aba08+dirty 2.92 MiB 3.41 MiB 499.03 KiB
8bda0cc+dirty 3.19 MiB 4.26 MiB 1.08 MiB
ad6c299+dirty 2.92 MiB 3.40 MiB 494.12 KiB
60d7316+dirty 3.19 MiB 4.30 MiB 1.12 MiB
d997097+dirty 3.19 MiB 4.26 MiB 1.08 MiB
0d3e677+dirty 2.92 MiB 3.66 MiB 758.42 KiB
7143e6f+dirty 3.19 MiB 4.26 MiB 1.08 MiB
7e87527+dirty 3.19 MiB 4.25 MiB 1.06 MiB
c639edf+dirty 2.92 MiB 3.64 MiB 742.55 KiB

antonis
antonis commented Mar 10, 2025
View reviewed changes
dev-packages/type-check/ts3.8-test/index.ts
@@ -20,6 +20,11 @@ declare global {
}
interface PerformanceEntry {}
}

declare module 'react-native' {
export interface TurboModule {}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was added due to the following type-check issue:

Error: node_modules/@sentry/react-native/ts3.8/dist/js/NativeRNSentry.d.ts(2,15): error TS2305: Module '"react-native"' has no exported member 'TurboModule'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich Awaiting requested review from krystofwoldrich krystofwoldrich is a code owner

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make getDataFromUri Public
1 participant
@antonis