Tracing without performance out of the box and deprecated Span.set_data()
#4223
+75
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## potel-base #4223 +/- ##
==============================================
+ Coverage 83.47% 83.49% +0.02%
==============================================
Files 143 143
Lines 14678 14631 -47
Branches 2332 2317 -15
==============================================
- Hits 12252 12216 -36
+ Misses 1709 1698 -11
Partials 717 717
|
There was a problem hiding this comment.
I am a bit confused by this PR; I am unsure what its purpose is supposed to be.
How does it relate to #4222? Did you mean to have it based on potel-base or master?
antonpirker
commented
Apr 1, 2025
| @@ -310,7 +336,10 @@ def test_records_lost_event_only_if_traces_sampler_enabled( | |||
| sampled_output, | |||
| expected_record_lost_event_calls, | |||
| ): | |||
| sentry_init(traces_sampler=traces_sampler) | |||
| sentry_init( | |||
| traces_sample_rate=None, | |||
There was a problem hiding this comment.
This test passes only if traces_sample_rate=None and it fails when it is 0 or 1.0. I am not sure if this is the excepted behavior.
|
Split this PR up into two: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #4102