Skip to content

chore: Deprecate Scope.user #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 26, 2025
Merged

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Mar 25, 2025

The docstring for Scope.user says it's deprecated in favor of Scope.set_user(), but there is no user-facing warning. Add one so that we can drop the property in the next major.

@sentrivana sentrivana marked this pull request as ready for review March 25, 2025 10:06
@sentrivana sentrivana requested a review from a team as a code owner March 25, 2025 10:06
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (ce0727f) to head (57a950f).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4194      +/-   ##
==========================================
+ Coverage   79.55%   79.57%   +0.02%     
==========================================
  Files         141      141              
  Lines       15737    15738       +1     
  Branches     2675     2675              
==========================================
+ Hits        12519    12523       +4     
+ Misses       2371     2369       -2     
+ Partials      847      846       -1     
Files with missing lines Coverage Δ
sentry_sdk/scope.py 85.59% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

Co-authored-by: Daniel Szoke <[email protected]>
@sentrivana sentrivana enabled auto-merge (squash) March 25, 2025 13:02
@sentrivana sentrivana merged commit 7406113 into master Mar 26, 2025
139 checks passed
@sentrivana sentrivana deleted the ivana/actually-deprecate-scope-user branch March 26, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants