fix: Provide es5 build for esm

[HazAT]

Fixes #1989
Fixes #1988
Fixes #1984
Fixes #1979

[HazAT]

cc @cromefire @vkrol

[getsentry-bot]

	Messages
📖	✅ TSLint passed
📖	@sentry/browser bundle gzip'ed minified size: (ES6: 14.2783 kB) (ES5: 15.6152 kB)

Generated by 🚫 dangerJS against 43f0f44

[cromefire]

But in this case it's hard/impossible to opt into es2015+

[cromefire]

It's up to the bundler, if it decides to select es2015 that is an issue of the bundler an not of Sentry. In the proposal I made esm + es5 is the default for module

[cromefire]

I looked around and found that for webpack you can set this to disable importing of es2015:

module.exports = {
    //...
    resolve: {
        mainFields: ['module', 'main']
    }
};

[vkrol]

@cromefire
As far as I know, webpack does not handle es2015 field in package.json.

[cromefire]

See this: https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/mobilebasic

[cromefire]

I skimmed the code and it seems to ignore it, but the opposite works:

module.exports = {
    //...
    resolve: {
        mainFields: ["es2015", "browser", 'module', 'main']
    }
};

[vkrol]

@cromefire Yes, webpack ignores this field and we need to configure them manually.

[cromefire]

It would be good if this gets added to the documentation

[vkrol]

@cromefire webpack documentation or Sentry documentation?

[cromefire]

It's in the webpack dos, but quite hidden, so the sentry docs, because the specific field es2015 is specific to apf.

Something like:

If you want webpack to use the modern es2015+ version of sentry add the following to you configuration:

module.exports = {
    //...
    resolve: {
        mainFields: ["es2015", "browser", 'module', 'main']
    }
};

Also see: webpack documentation

[HazAT]

Yes, @cromefire I found this too but I am still confused now

So, we will do:

module = es5 syntax with module imports (esm)
es2015 = es2015 syntax with module imports (esm)

right?

[HazAT]

I decided not to emit es2015 yet since it's only for angular, and angular also works with just module if it's es5.

[cromefire]

es5 works but it's es5, so it's deprecated since 4 Years

[cromefire]

I'm preparing a PR that implements everything

[cromefire]

Yes, @cromefire I found this too but I am still confused now

So, we will do:

module = es5 syntax with module imports (esm)
es2015 = es2015 syntax with module imports (esm)

right?

Yes

[HazAT]

@cromefire I will still release 5.0.5 now since it's unbreaking builds, we can take our time then to fix everything properly and provide all possible builds

[vkrol]

@cromefire what do you think about this?

This works for ES2015, but it begs the question of what we should do about ES2016? Are we supposed to create a new folder for each year and a new field in package.json? That seems unsustainable, and will continue to produce larger node_modules.

https://babeljs.io/blog/2018/06/26/on-consuming-and-publishing-es2015+-packages#non-scalable-solutions

[cromefire]

Well right now the es2015 builds are es2015+ right now

[vkrol]

@cromefire please, can you elaborate more on that?

[cromefire]

They are 1:1 the source code, so what ever the source is, is the result

[cromefire]

That means that you are in charge of what will be in the output and have to look that your code runs in the latest browsers

[cromefire]

https://babeljs.io/blog/2018/06/26/on-consuming-and-publishing-es2015+-packages#non-scalable-solutions

We could also publish it under esnext, rather than es2015

[cromefire]

If got some basic builds working with only minor problems

[cromefire]

For today just for @sentry/browser

[cromefire]

Because of the utils I also have to get my rewrite script up and running again

[HazAT]

@cromefire I don't want to have a rewrite script, we have to solve it differently even if it means to build utils different

[cromefire]

Then index cannot have deep imports

[HazAT]

I know, but we expose a index then in utils to fix this

[cromefire]

Indeed that would be the solution, but this may make the bundle larger depending on tree shaking