feat(node): Add ignoreIncomingRequestBody callback to httpIntegration

[Page-]

This allows ignoring the request body for certain requests, which is very useful in situations of long-running requests with large/streaming request bodies which can result in a lot of memory usage

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

• If you've added code that should be tested, please add tests.
• Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

[Lms24]

Hey @Page-, thanks for opening this PR! The proposal sounds reasonable to me. I'll also tag @mydea for input. Let me know if you have questions or need assistance to get this ready for review :)

By the way, if there's an issue for this, please link it in the PR description, thanks!

[Page-]

@Lms24 the main reason I still have it as draft is to be able to check the build/lint/tests on a linux VM as windows isn't supported. I was able to build/run just the specific parts I changed whilst on windows but that was with heavy modification and hence wanting to double check in an environment with just the feature change and not the workarounds.

There isn't an issue associated with this (as far as I know) but I can create one to link to if you want?

[Lms24]

Hey, thanks for getting back to me!

Usually it'd be best to start off with an issue (after which we'd still gladly accept a PR of course 😅). Since the PR is already here, no need for it now.

This change looks good to me so I'll approve it. Still waiting on comments from other team members before merging it.

[Lms24]

I just made one more change to also add the new option to the HttpOptions of httpIntegration. This is easy to miss because onfortunately we have an unknown in the type chain that makes TS not complain about the missing property when we initialize the SentryHttpInstrumentation.

Talked to the team and everyone is fine with the change. So I'm gonna merge it. Thanks for contributing!

[Page-]

Awesome, thanks for the quick response @Lms24. And I agree on the issue, it was just a case that by the time I tracked down the memory usage I was already in the place to fix it :)