fix(node): Ensure incoming traces are propagated without HttpInstrumentation #15732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
chargome
approved these changes
Mar 19, 2025
| ...options, | ||
| // If spans are not instrumented, it means the HttpInstrumentation has not been added | ||
| // In that case, we want to handle incoming trace extraction ourselves | ||
| extractIncomingTraceFromHeader: !instrumentSpans, |
mergify bot
added a commit
to reisene/HulajDusza-serwis
that referenced
this pull request
Apr 11, 2025
 [<img width="16" alt="Powered by Pull Request Badge" src="https://user-images.githubusercontent.com/1393946/111216524-d2bb8e00-85d4-11eb-821b-ed4c00989c02.png">](https://pullrequestbadge.com/?utm_medium=github&utm_source=reisene&utm_campaign=badge_info)<!-- PR-BADGE: PLEASE DO NOT REMOVE THIS COMMENT -->  <h3>Snyk has created this PR to upgrade @sentry/browser from 9.6.1 to 9.7.0.</h3> :information_source: Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project. <hr/> - The recommended version is **2 versions** ahead of your current version. - The recommended version was released **22 days ago**. <details> <summary><b>Release notes</b></summary> <br/> <details> <summary>Package name: <b>@sentry/browser</b></summary> <ul> <li> <b>9.7.0</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/9.7.0">2025-03-20</a></br><ul> <li>feat(core): Add <code>captureLog</code> method (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15717" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15717/hovercard">#15717</a>)</li> <li>feat(remix/cloudflare): Export <code>sentryHandleError</code> (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15726" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15726/hovercard">#15726</a>)</li> <li>fix(node): Always flush on Vercel before Lambda freeze (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15602" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15602/hovercard">#15602</a>)</li> <li>fix(node): Ensure incoming traces are propagated without HttpInstrumentation (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15732" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15732/hovercard">#15732</a>)</li> <li>fix(node): Use <code>fatal</code> level for unhandled rejections in <code>strict</code> mode (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15720" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15720/hovercard">#15720</a>)</li> <li>fix(nuxt): Delete Nuxt server template injection (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15749" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15749/hovercard">#15749</a>)</li> </ul> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.28 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>23.09 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>36.33 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.5 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>66.93 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>78.13 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>90.69 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.42 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.91 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.7 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>25.08 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.23 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.52 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>38.02 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.3 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.49 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>36.37 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>71.39 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>76.57 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.56 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>107.94 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>219.2 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>231.77 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>39.52 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.73 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>142.62 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>96.01 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>120.37 KB</td> </tr> </tbody> </table> </li> <li> <b>9.7.0-alpha.0</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/9.7.0-alpha.0">2025-03-19</a></br><p>This is an alpha release that includes experimental features which are subject to breaking changes.</p> <ul> <li>fix(node): Ensure httpIntegration propagates traces <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2931703262" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#15735" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15735/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/15735">#15735</a></li> <li>feat(browser): Attach top-level domain to "Failed to fetch" errors <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2931296276" data-permission-text="Title is private" data-url="getsentry/sentry-javascript#15729" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15729/hovercard" href="https://redirect.github.com/getsentry/sentry-javascript/pull/15729">#15729</a></li> </ul> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.26 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>23.07 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>36.32 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.5 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>66.92 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>78.13 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>90.68 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.4 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.9 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.68 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>25.07 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.21 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.51 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>38.01 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.29 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.48 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>36.36 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>71.38 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>76.56 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.45 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>107.83 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>219.09 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>231.66 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>39.48 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.72 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>142.8 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>96.15 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>120.54 KB</td> </tr> </tbody> </table> </li> <li> <b>9.6.1</b> - <a href="https://redirect.github.com/getsentry/sentry-javascript/releases/tag/9.6.1">2025-03-19</a></br><ul> <li>feat(deps): bump @ prisma/instrumentation from 6.4.1 to 6.5.0 (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15714" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15714/hovercard">#15714</a>)</li> <li>feat(deps): bump @ sentry/cli from 2.42.2 to 2.42.3 (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15711" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15711/hovercard">#15711</a>)</li> <li>fix(nextjs): Re-patch router if it is overridden by Next.js (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15721" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15721/hovercard">#15721</a>)</li> <li>fix(nuxt): Add Nitro Rollup plugin to inject Sentry server config (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15710" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15710/hovercard">#15710</a>)</li> <li>chore(deps): Bump rollup to 4.35.0 (<a href="https://redirect.github.com/getsentry/sentry-javascript/pull/15651" data-hovercard-type="pull_request" data-hovercard-url="/getsentry/sentry-javascript/pull/15651/hovercard">#15651</a>)</li> </ul> <h2>Bundle size 📦</h2> <table> <thead> <tr> <th>Path</th> <th>Size</th> </tr> </thead> <tbody> <tr> <td>@ sentry/browser</td> <td>23.15 KB</td> </tr> <tr> <td>@ sentry/browser - with treeshaking flags</td> <td>22.94 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing)</td> <td>36.21 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay)</td> <td>73.39 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay) - with treeshaking flags</td> <td>66.81 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay with Canvas)</td> <td>78.01 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Tracing, Replay, Feedback)</td> <td>90.57 KB</td> </tr> <tr> <td>@ sentry/browser (incl. Feedback)</td> <td>40.3 KB</td> </tr> <tr> <td>@ sentry/browser (incl. sendFeedback)</td> <td>27.79 KB</td> </tr> <tr> <td>@ sentry/browser (incl. FeedbackAsync)</td> <td>32.58 KB</td> </tr> <tr> <td>@ sentry/react</td> <td>24.97 KB</td> </tr> <tr> <td>@ sentry/react (incl. Tracing)</td> <td>38.1 KB</td> </tr> <tr> <td>@ sentry/vue</td> <td>27.4 KB</td> </tr> <tr> <td>@ sentry/vue (incl. Tracing)</td> <td>37.9 KB</td> </tr> <tr> <td>@ sentry/svelte</td> <td>23.18 KB</td> </tr> <tr> <td>CDN Bundle</td> <td>24.36 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing)</td> <td>36.26 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay)</td> <td>71.27 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback)</td> <td>76.45 KB</td> </tr> <tr> <td>CDN Bundle - uncompressed</td> <td>71.19 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing) - uncompressed</td> <td>107.57 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay) - uncompressed</td> <td>218.83 KB</td> </tr> <tr> <td>CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed</td> <td>231.39 KB</td> </tr> <tr> <td>@ sentry/nextjs (client)</td> <td>39.38 KB</td> </tr> <tr> <td>@ sentry/sveltekit (client)</td> <td>36.63 KB</td> </tr> <tr> <td>@ sentry/node</td> <td>142.29 KB</td> </tr> <tr> <td>@ sentry/node - without tracing</td> <td>95.71 KB</td> </tr> <tr> <td>@ sentry/aws-serverless</td> <td>120.06 KB</td> </tr> </tbody> </table> </li> </ul> from <a href="https://redirect.github.com/getsentry/sentry-javascript/releases">@sentry/browser GitHub release notes</a> </details> </details> --- > [!IMPORTANT] > > - Check the changes in this PR to ensure they won't cause issues with your project. > - This PR was automatically created by Snyk using the credentials of a real user. --- **Note:** _You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs._ **For more information:** <img src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIyZjNjN2Q2OS0yYWEwLTQ0MTgtODViZC04ODRhNGUzOTFlNmEiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjJmM2M3ZDY5LTJhYTAtNDQxOC04NWJkLTg4NGE0ZTM5MWU2YSJ9fQ==" width="0" height="0"/> > - 🧐 [View latest project report](https://app.snyk.io/org/reisene/project/3b48baaa-833b-4239-b348-16091472ee83?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 📜 [Customise PR templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template) > - 🛠 [Adjust upgrade PR settings](https://app.snyk.io/org/reisene/project/3b48baaa-833b-4239-b348-16091472ee83/settings/integration?utm_source=github&utm_medium=referral&page=upgrade-pr) > - 🔕 [Ignore this dependency or unsubscribe from future upgrade PRs](https://app.snyk.io/org/reisene/project/3b48baaa-833b-4239-b348-16091472ee83/settings/integration?pkg=@sentry/browser&utm_source=github&utm_medium=referral&page=upgrade-pr#auto-dep-upgrades) [//]: # 'snyk:metadata:{"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@sentry/browser","from":"9.6.1","to":"9.7.0"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"2f3c7d69-2aa0-4418-85bd-884a4e391e6a","prPublicId":"2f3c7d69-2aa0-4418-85bd-884a4e391e6a","packageManager":"npm","priorityScoreList":[],"projectPublicId":"3b48baaa-833b-4239-b348-16091472ee83","projectUrl":"https://app.snyk.io/org/reisene/project/3b48baaa-833b-4239-b348-16091472ee83?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":2,"publishedDate":"2025-03-20T13:28:41.863Z"},"vulns":[]}' ## Podsumowanie od Sourcery Aktualizacja zależności @sentry/browser z wersji 9.6.1 do 9.7.0 Nowe funkcje: - Dodano metodę captureLog - Eksport sentryHandleError dla Remix/Cloudflare Poprawki błędów: - Naprawiono obsługę nieobsłużonych odrzuceń w trybie ścisłym - Zapewniono propagację przychodzących śladów (traces) - Naprawiono wstrzykiwanie szablonu serwera Nuxt <details> <summary>Original summary in English</summary> ## Summary by Sourcery Upgrade @sentry/browser dependency from version 9.6.1 to 9.7.0 New Features: - Add captureLog method - Export sentryHandleError for Remix/Cloudflare Bug Fixes: - Fix unhandled rejections handling in strict mode - Ensure incoming traces are propagated - Fix Nuxt server template injection </details>
<!--](https://user-images.githubusercontent.com/1393946/111216524-d2bb8e00-85d4-11eb-821b-ed4c00989c02.png">](https://pullrequestbadge.com/?utm_medium=github&utm_source=reisene&utm_campaign=badge_info)<!--){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15730
Noticed that this is not really happening otherwise, so if we are not adding the
HttpInstrumentationwe now make sure to extract incoming traces ourselves! This will unlock us not adding that instrumentation when tracing is disabled.Also includes #15731 as a side effect.