Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow apf #1979

Closed
4 of 8 tasks
cromefire opened this issue Apr 2, 2019 · 11 comments
Closed
4 of 8 tasks

Follow apf #1979

cromefire opened this issue Apr 2, 2019 · 11 comments

Comments

@cromefire
Copy link
Contributor

cromefire commented Apr 2, 2019

Package + Version

  • @sentry/browser
  • @sentry/node
  • raven-js
  • raven-node (raven for node)
  • other:

Version:

5.0.2

Description

The Angular Package Format defines esm2015 as the field to use for esm + es2015 so that should be used to denote esm instead of module

Ref: #1973 (comment)
Angular Package Format

@HazAT
Copy link
Member

HazAT commented Apr 2, 2019

Note, this was angular emits:

  "name": "@angular/core", 
  "module": "./fesm5/core.js", 
  "es2015": "./fesm2015/core.js", 
  "esm5": "./esm5/core.js",
  "esm2015": "./esm2015/core.js",
  "fesm5": "./fesm5/core.js",
  "fesm2015": "./fesm2015/core.js",
  "main": "bundles/core.umd.js", 
  "typings": "core.d.ts",
  "sideEffects": false

I would like to emit an additional build to fix this instead of replacing it, wdyt?

@cromefire
Copy link
Contributor Author

It's hard to produce fesm

@HazAT
Copy link
Member

HazAT commented Apr 2, 2019

Why is it hard, shouldn't it just be target es2015 and module es6?

@cromefire
Copy link
Contributor Author

You have to put everything into a single module file

@cromefire
Copy link
Contributor Author

That's the difference of fesm vs. esm, but you could think of producing the other things excluding fesm, but it would be good if we had a top level file in utils to enable resolution using that mechanism

@cromefire
Copy link
Contributor Author

Okay I looked around a bit and it seems that people just use rollup in es mode for fesm so that's easy

@HazAT
Copy link
Member

HazAT commented Apr 2, 2019

@cromefire I would really prefer to have this in addition to module instead of replacing it.
Thanks for investigating tho

@cromefire
Copy link
Contributor Author

Module is also in the apm standard

@cromefire
Copy link
Contributor Author

But provides (f)esm5

@HazAT
Copy link
Member

HazAT commented Apr 3, 2019

@cromefire what do you think?
#1989 (comment)

@cromefire
Copy link
Contributor Author

cromefire commented Apr 3, 2019

This is more that proposed in #1989

@cromefire cromefire changed the title Replace module field with esm2015 Follow apf Apr 3, 2019
@cromefire cromefire mentioned this issue Apr 4, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants