-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native): add view hierarchy docs #13191
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 228 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: sentry-docs-server-cjsAssets Changed:
view changes for bundle: sentry-docs-client-array-pushAssets Changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should document this option? It does not make much sense to direct SDK users; it is primarily for downstream SDKs. If we document it here, we must signal the primary use case (something similar to "You will never have to set this yourself; a downstream SDK built on top of the Native SDK will usually provide the view hierarchy for you").
It would also be good to mention this in the header inline docs.
CC: @kahest
@supervacuus Since the view-hierarchy inherently doesn't make a lot of sense in a Native setting, I think you're right about not needing it documented here. I'm fine with closing this PR. |
As the feature isn't meant to be native-user-facing, but rather as a functionality consumed by downstream SDKs, we opt to not document its use here. |
DESCRIBE YOUR PR
Related to getsentry/sentry-native#1191
Vercel Preview of the relevant page
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: