Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): Remove deprecated ErrorBoundary options. #13170

Merged
merged 1 commit into from
Mar 31, 2025

Conversation

onurtemizkan
Copy link
Collaborator

Remix roots are not wrapped with @sentry/react's ErrorBoundary starting from Remix version 2.

We dropped support for Remix v1, so the docs are not valid anymore.

Resolves: getsentry/sentry-javascript#15883

Copy link

vercel bot commented Mar 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2025 3:14pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Mar 31, 2025 3:14pm
develop-docs ⬜️ Ignored (Inspect) Mar 31, 2025 3:14pm

Copy link

codecov bot commented Mar 31, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.61MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.44MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 868.67kB -0.0%
static/chunks/8931-*.js -3 bytes 397.42kB -0.0%
static/fAlKRSJnKt4cSyLRMjStV/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/fAlKRSJnKt4cSyLRMjStV/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/oWDKXWNl_DQrLrJUysx5W/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/oWDKXWNl_DQrLrJUysx5W/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 911.63kB -0.0%
9523.js -3 bytes 887.68kB -0.0%

@AbhiPrasad AbhiPrasad merged commit 34ab23d into master Mar 31, 2025
11 checks passed
@AbhiPrasad AbhiPrasad deleted the onur/remove-remix-error-boundary branch March 31, 2025 15:53
AbhiPrasad pushed a commit to getsentry/sentry-javascript that referenced this pull request Apr 2, 2025
onurtemizkan added a commit to getsentry/sentry-javascript that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants