Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(solidstart): Add docs for installation methods #12335

Merged
merged 3 commits into from
Feb 17, 2025

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Jan 14, 2025

DESCRIBE YOUR PR

⚠️ only merge when v9 is released

closes #12279

docs for those PRs:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

@s1gr1d s1gr1d requested a review from andreiborza January 14, 2025 15:16
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 3:15pm
develop-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 3:15pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 3:15pm

@s1gr1d s1gr1d requested a review from codyde January 14, 2025 15:17
Copy link

codecov bot commented Jan 14, 2025

Bundle Report

Changes will increase total bundle size by 990 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB 996 bytes (0.01%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 335 bytes 377.92kB 0.09%
../app/platform-redirect/page.js.nft.json 335 bytes 377.83kB 0.09%
../app/sitemap.xml/route.js.nft.json 335 bytes 375.8kB 0.09%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/g80Iz62jixJmObj5u3oZy/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/g80Iz62jixJmObj5u3oZy/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/MXzSxbuvAR6uiMJNji1nU/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/MXzSxbuvAR6uiMJNji1nU/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

Copy link
Member

@andreiborza andreiborza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@getsantry
Copy link
Contributor

getsantry bot commented Feb 7, 2025

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Feb 7, 2025
@s1gr1d s1gr1d removed the Stale label Feb 7, 2025
@s1gr1d s1gr1d marked this pull request as ready for review February 17, 2025 14:57
@s1gr1d s1gr1d merged commit 1fc7506 into master Feb 17, 2025
11 checks passed
@s1gr1d s1gr1d deleted the sig/solidstart-withSentry branch February 17, 2025 15:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SolidStart] Update setup docs based on new withSentry method
2 participants