Remove tests from the wheel and simplify setup.py. #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wheel beforeWheel afterNote that the source dist still contains: |
|
Thanks for putting this together. The lint build is failing, but I'm not convinced the failure is related to your changes. |
markstory
added a commit
that referenced
this pull request
Jan 9, 2025
markstory
added a commit
that referenced
this pull request
Jan 10, 2025
This was referenced Jan 12, 2025
|
@markstory I recall there was an issue with discussion in the past. I think these tests are used in Debian package or something like for autotests |
|
Ah good to check, but I would expect that is the source distribution which does still have tests. |
It needed a one-line adjustment to the Debian package to run the tests from the source tree rather than assuming they'd be in the built tree, but that was trivial enough and I've done it now. |
|
@cjwatson paths are crossing again :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the tests/ directory from the wheel distribution of
responses. Wheels are intended to be a production release containing no tests.Update setup.py removing
include_package_dataarg, which causes the wheel to contain the tests. Add a pyproject.toml with setup requires and a build backend. Remove references to the deprecated test command of setup tools.