This repository was archived by the owner on Oct 23, 2023. It is now read-only.
Ensure that all keys in locals are strings before serializing #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This took really long to find, because of #1155 masking the real error, BTW. It would be nice if an exception during serialization wouldn't fail with a confusing message on Python3. Here's the line in trio that adds a guard object into locals: |
Trio uses an ugly hack and puts a value into locals with a non string key (class LOCALS_KI_PROTECTION_ENABLED). When trying to serialize that, JsonEncoder crashes. So we ensure that every key is indeed a string. Another way to solve this problem would be to pass skipkeys=True to json.dumps, but this might mask other errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trio uses an ugly hack and puts a value into locals with a
non string key (class LOCALS_KI_PROTECTION_ENABLED).
When trying to serialize that, JsonEncoder crashes.
So we ensure that every key is indeed a string.
Another way to solve this problem would be to pass skipkeys=True
to json.dumps, but this might mask other errors.