-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse logs for FOSSA action to determine actual license scan failures #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubertdeng123
force-pushed
the
hubertdeng123/parse-logs-fossa
branch
from
April 11, 2023 01:21
3fb62d1
to
c5d31c3
Compare
hubertdeng123
force-pushed
the
hubertdeng123/parse-logs-fossa
branch
from
April 13, 2023 17:51
b53e179
to
c8b80ad
Compare
hubertdeng123
force-pushed
the
hubertdeng123/parse-logs-fossa
branch
from
April 13, 2023 20:45
22f74c0
to
bcddb95
Compare
hubertdeng123
changed the title
Test: Parse logs for FOSSA action
Parse logs for FOSSA action to determine actual license scan failures
Apr 13, 2023
9 tasks
hubertdeng123
force-pushed
the
hubertdeng123/parse-logs-fossa
branch
from
April 19, 2023 17:32
f09b96e
to
5361b52
Compare
hubertdeng123
force-pushed
the
hubertdeng123/parse-logs-fossa
branch
from
April 19, 2023 17:34
5361b52
to
2deb658
Compare
action.yml
Outdated
fi | ||
curl -sL https://sentry.io/get-cli/ | sh | ||
error_msg=$(cat test_logs.txt | grep -zoP '(?<=>>> Relevant errors\n\n Error\n\n ).*?(?=\n)' || echo 'unknown error message') | ||
sentry-cli send-event -m "FOSSA test error: $error_msg" -t repo:$GITHUB_REPOSITORY -e url:$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID --logfile test_logs.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's trim this up here and in the analyze case so we get more of the useful error message in the UI.
Suggested change
sentry-cli send-event -m "FOSSA test error: $error_msg" -t repo:$GITHUB_REPOSITORY -e url:$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID --logfile test_logs.txt | |
sentry-cli send-event -m "test: $error_msg" -t repo:$GITHUB_REPOSITORY -e url:$GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID --logfile test_logs.txt |
chadwhitacre
approved these changes
Apr 19, 2023
36 tasks
This was referenced Apr 24, 2023
hubertdeng123
added a commit
to getsentry/sentry
that referenced
this pull request
Apr 25, 2023
This PR re-enables FOSSA license compliance scans. The action has been running for a few days now in all repos except `getsentry`, `snuba`, and `sentry` without issues. Changes have been made to the action to make sure it is more resilient to FOSSA errors (outages, network issues) Here's the relevant PR in the license scan action: getsentry/action-enforce-license-compliance#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses FOSSA scan logs to check for error or specific license scanning failure. closes getsentry/team-ospo#124
FOSSA connection failure still passing CI: https://github.com/getsentry/sentry/actions/runs/4682991144/attempts/1
FOSSA connection license scan failure failing CI: https://github.com/getsentry/sentry/actions/runs/4692294461/attempts/1
FOSSA license scan success passing CI: https://github.com/getsentry/sentry/actions/runs/4702538858/jobs/8342542104?pr=47273
FOSSA timeout but still passing CI: https://github.com/getsentry/sentry/actions/runs/4702538858/jobs/8339925767?pr=47273