Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3785 — Ignore errors in parsing SVG files for shrinking them, copy original file to output instead #3787

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

Kwpolska
Copy link
Member

We already have this fallback for any errors for raster images. This fixes #3785.

@Kwpolska Kwpolska added the bug label Aug 26, 2024
@Kwpolska
Copy link
Member Author

@Xaldew, could you test this fix?

@Kwpolska Kwpolska force-pushed the fix-3785-ignore-lxml-failure-in-thumbnail-generation branch from 71f44b6 to 9ae15ba Compare August 28, 2024 20:02
@Kwpolska Kwpolska merged commit 168d9cd into master Aug 28, 2024
11 checks passed
@Kwpolska Kwpolska deleted the fix-3785-ignore-lxml-failure-in-thumbnail-generation branch August 28, 2024 20:41
@Xaldew
Copy link

Xaldew commented Sep 5, 2024

@Kwpolska

Apologies for the slow response! But yes, I can confirm that this works:

xaldew@ShadowX:~/git/homepage/nikola_blog$ make
nikola build
Scanning posts............done!
.  scale_images:output/images/compression-teaser.opt.svg
[2024-09-05 10:31:10] WARNING: scale_images: Can't process images/compression-teaser.opt.svg, using original image! (Memory allocation failed : Huge input lookup, line 42, column 10000034 (<string>, line 42))
[2024-09-05 10:31:10] WARNING: scale_images: Can't process images/compression-teaser.opt.svg, using original image! (Memory allocation failed : Huge input lookup, line 42, column 10000034 (<string>, line 42))

Perhaps a bit wierd that it writes the error message twice, but that's hardly a real issue.

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Large" SVG files can crash build
2 participants