Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derra branch Mine functions I improved the coverage for #3780

Closed
wants to merge 10 commits into from

Conversation

DarianTheGoat1
Copy link

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable).
  • I tested my changes.

Description

Copy link
Member

@Kwpolska Kwpolska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not how code coverage works. To increase the code coverage, you should write tests that exercise the edge cases, but also verify the output makes sense.

You should not add things like branch_coverage, report_coverage, reset_coverage to the code. You should change as little as possible in the production code (only change the tests, maybe adjust the production code to make it more testable).

@Kwpolska Kwpolska closed this Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants