Add Micrometer integration to ktor client #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
I went back and forth trying to add micrometer support to platform request, by either changing the kevin-jvm library or by changing banking-service.
Here's what I've tried or considered to have metrics for a web clients for platform request:
I do not like much any of this approaches, maybe the best option is to wait and use a common web-client in some time.
But by adding Micrometer to kevin-jvm, i just had to change 2 lines in banking-service and the metrics were correctly updated with
http_client_requests
and it worked pretty good. Down below the response to the metrics where you can see the http_client_requests values from ktor (@Mantas-Ragauskas also please see the hibernate metrics that I have added and tell me what you think)So, my question is, does this PR make sense or should we wait to add Spring's webclient in banking-service (where adding metrics is easy) and replicate kevin-jvm requests there ???