Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding reminder for inclusive pronouns Issue #297 #345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jfreud1
Copy link

@jfreud1 jfreud1 commented Dec 5, 2023

Closes issue #297
This implementation is for the second solution proposed in the issue "More Helpful Response to He/Her Pronouns"
Let us know what you think! Our changes were made to index.js
this function is intended to remind the user to confirm the proper pronouns of the subjects in the text when pronouns are detected

@wooorm
Copy link
Member

wooorm commented Jan 11, 2024

Thanks for your PR and your patience!

That issue is open because I have feedback on it that has not been addressed by the original poster. To recap: it sounds like the user knows perfectly well what to do. I am not sure this feature is needed. More here: #297 (comment).

I am not sure a message is needed for this.
And I am not sure about randomly logging messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants