Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CITE tests to the production images where possible #8169

Merged
merged 7 commits into from
Dec 31, 2024

Conversation

aaime
Copy link
Member

@aaime aaime commented Dec 30, 2024

This PR updates a number of CITE tests and switches them to the production docker image of the teamengine, starting them up with the REST API. Exceptions:

  • WCS 1.0 has no way to be started with REST, I would not hold my breath waiting for it and the process is not immediate, here is a WCS 1.1 example for reference (and they did not have to split the CTL files into per-request sub-files). I also could not get to pass the test suite due to some oddball issue invoking a XSTL function... however, running the WCS 1.0 CITE tests from the web interface works (so it could be used for certification, even if we cannot keep tabs on it).
  • WFS 1.1 fail to work when invoked through the REST API, apparently due to a Teamengine packaging issue. When that is fixed, we can switch this one to latest as well.

In order to get things passing with all the suites, I had to centralized the version negotiation, and pull some hacks to identify the version of ServiceException the WCS test demand (they don't provide the version number, and assume one still responds with the ServiceException from the WCS being tested).

Checklist

For core and extension modules:

  • New unit tests have been added covering the changes.
  • Documentation has been updated (if change is visible to end users).
  • The REST API docs have been updated (when changing configuration objects or the REST controllers).
  • There is an issue in the GeoServer Jira (except for changes that do not affect administrators or end users in any way).
  • Commit message(s) must be in the form [GEOS-XYZWV] Title of the Jira ticket.
  • Bug fixes and small new features are presented as a single commit.
  • Each commit has a single objective (if there are multiple commits, each has a separate JIRA ticket describing its goal).

Copy link
Member

@groldan groldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@aaime aaime merged commit 894e65c into geoserver:main Dec 31, 2024
16 checks passed
@aaime aaime deleted the cite_rest branch December 31, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants