Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1083: Removed default icon set 'babs' from UNLISTED_ICON_SET #93

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Commits on Nov 13, 2024

  1. PB-1083: Removed default icon set 'babs' from UNLISTED_ICON_SET

    This change helps us avoid changing UNLISTED_ICON_SET's content on both
    the service and the k8s configuration.
    
    In order to achieve this, I'm assigning an empty string '' (since
    os.environ.get requires a default value), and removing that string with a
    simple loop.
    Sami Nouidri committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    b878f12 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. PB-1083 : re-factored UNLISTED_ICON_SETS to be fetched with a function

    This change improves readability of settings.py, and removes the double
    assignement, with a cleaner overall routine.
    
    UNLISTED_ICON_SETS is now assigned in settings.py using the function
    fetch_and_clean_unlisted_sets.
    Sami Nouidri committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    3686f51 View commit details
    Browse the repository at this point in the history