PB-1083: Add simple versioning

[sami-nouidri-swisstopo]

Issue :

The old folder structure & naming scheme lacked simple versioning in its denomination. As such, it needs to be changed to reflect the version number. Legacy icons in /static/images/babs are not affected.

Fix:

The folder structure has been renamed, and all references to existing babs-{LANG} icon sets have been changed to reflect the new naming scheme.

[schtibe]

I think the code is OK apart from the changes in logging-cfg-local.yml. Maybe look into that again if you really need these.

Now for the commit messages: I thought we had a guideline on those, but I can't find them. Maybe @ltshb knows.

Usually we put the ticket number in front. Also, I think it's common to use the imperative, see this: https://cbea.ms/git-commit/#imperative

[schtibe]

Interesting. I think this was upper case because this was read by python? You shouldn't be needing ansible-lint here?

[ltkum]

I was checking that : the default for yaml boolean capitalization for yaml linter is all lowercase. I would be in favor of keeping it as Sami did, since it would bring the config file to a standard value.

With that being said, it would be best to also do so in the base template and be consistent across all repos, but those are small changes.

[sami-nouidri-swisstopo]

Oh, that makes sense. I just ran lint on the whole project, I'm assuming then that you only run it on code files?

[ltkum]

looks good to me :)

[ltkum]

Now for the commit messages: I thought we had a guideline on those, but I can't find them. Maybe @ltshb knows.

The commit messages should be :

{TICKET_ID}: summary of the changes
- change 1
- change 2

(if the summary is explicit by itself, no need for a list of changes).

[sami-nouidri-swisstopo]

Now for the commit messages: I thought we had a guideline on those, but I can't find them. Maybe @ltshb knows.

The commit messages should be :

{TICKET_ID}: summary of the changes
- change 1
- change 2

(if the summary is explicit by itself, no need for a list of changes).

I'll keep that in mind, I don't think I can change commit messages now 😄

[ltshb]

Now for the commit messages: I thought we had a guideline on those, but I can't find them. Maybe @ltshb knows.

The commit messages should be :

{TICKET_ID}: summary of the changes
- change 1
- change 2

(if the summary is explicit by itself, no need for a list of changes).

@ltkum @schtibe @sami-nouidri-swisstopo the commit message from @ltkum is not 100% correct:

PB-XXX: Summary of the changes (should be less than 100 character and one line)
BLANK LINE !
What is the problem that the commit try to solve

How and why you solve the problem this way

Listing changes that can be easily seen in code diff in commit message don't help, it help more to add description on the why and how to understand the changes.

See https://github.com/geoadmin/doc-guidelines/blob/master/GIT_FLOW.md#pull-request-rules

[sami-nouidri-swisstopo]

Now for the commit messages: I thought we had a guideline on those, but I can't find them. Maybe @ltshb knows.

The commit messages should be :

{TICKET_ID}: summary of the changes
- change 1
- change 2

(if the summary is explicit by itself, no need for a list of changes).

@ltkum @schtibe @sami-nouidri-swisstopo the commit message from @ltkum is not 100% correct:

PB-XXX: Summary of the changes (should be less than 100 character and one line)
BLANK LINE !
What is the problem that the commit try to solve

How and why you solve the problem this way

Listing changes that can be easily seen in code diff in commit message don't help, it help more to add description on the why and how to understand the changes.

See https://github.com/geoadmin/doc-guidelines/blob/master/GIT_FLOW.md#pull-request-rules

Good to know, thanks. I should look to making my future commits with VS Code, as writing verbose messages is not easy in command line

[schtibe]

For those doing it with (n)vim: if the configuration is correct, it shows if there are problems: