Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-508: Add UNLISTED_ICON_SETS environment so we can unlist some sets on different staging #88

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

LukasJoss
Copy link
Contributor

@LukasJoss LukasJoss commented Sep 12, 2024

This allow to have some sets on INT staging but not on PROD for validations.

@LukasJoss LukasJoss changed the title unlist new babs icon sets so that new image can be made for mapviewer… PB-508: Unlist new babs icon sets so that new image can be made for mapviewer… Sep 12, 2024
@LukasJoss
Copy link
Contributor Author

LukasJoss commented Sep 12, 2024

This PR would unlist the new babs icon-sets and relist the original babs icon set for creating a new image so that geoadmin/web-mapviewer#1064 can be merged into master since it requires an endpoint from service-icons which is not available on the current image of service-icons running on prod

app/settings.py Outdated Show resolved Hide resolved
By default un-list the future legacy babs.
@ltshb ltshb requested a review from pakb September 12, 2024 11:44
@ltshb ltshb changed the title PB-508: Unlist new babs icon sets so that new image can be made for mapviewer… PB-508: Add UNLISTED_ICON_SETS environment so we can unlist some sets on different staging Sep 12, 2024
Copy link
Member

@hansmannj hansmannj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, LGTM!

@ltshb ltshb merged commit 35235fd into develop Sep 12, 2024
7 checks passed
@ltshb ltshb deleted the unlist-new-babs-icon-sets branch September 12, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants