PB-227: Update language #86
Conversation
|
@hansmannj @pakb What do you think of renaming the babs foldes to that they use iso-code language abbreviations (e.g babs-I -> babs-it). I prefer it, but it is no longer consistent with the names of the icons |
app/icon_set.py
Outdated
| @@ -121,5 +121,6 @@ def serialize(self): | |||
| "colorable": self.colorable, | |||
| "icons_url": self.get_icons_url(), | |||
| "template_url": get_icon_set_template_url(get_base_url()), | |||
| "has_description": bool(find_descripton_file(self.name)) | |||
| "has_description": bool(find_descripton_file(self.name)), | |||
| "language": self.name.split('-')[-1] if '-' in self.name else False | |||
There was a problem hiding this comment.
Not sure, if this logic will do for all cases.
For example a file called "001-Beschaedigung.png" would lead to a wrong language.
There was a problem hiding this comment.
We might take the language from the directory or the icon-set name respectively.
In that case we need to make sure, that the language is always part of the icon set name.
Why do we need the language in the first place?
There was a problem hiding this comment.
this is for the icon set, not the icons
There was a problem hiding this comment.
we need the language so we can properly translate the icon set selector dropdown on the mapviewer
There was a problem hiding this comment.
Ah, stupid me 🙈
Of course, that makes sense then!
There was a problem hiding this comment.
In this case, we need to document and make sure, that all (new) icon sets are always named correctly and don't include - unless for adding a language.
There was a problem hiding this comment.
That touches our architectural decissions @boecklic
There was a problem hiding this comment.
I can also use a dictionary if that is preferable
There was a problem hiding this comment.
I have replaced it with a dictionary for now, we can change it back later if necessary
There was a problem hiding this comment.
Thanks! I had a similar idea later yesterday evening.
Slightly diferent and a bit more generic, without having to hardcode the icon-set's languages.
We could have a list with the languages we support, i.e. SUPPORTED_LANGUAGES = ["FR", "IT", "RM", "DE", "EN"] for example.
Then we can use your approach you had in a few commits before, i.e. trying to get the icon-set's language from the name/path. Then check, if the derived language is in our list of supported languages.
If it is: bingo, else None for the language.
How about that?
LukasJoss
force-pushed
the
feat-PB-227-update-language
branch
from
6e24e53
to
43e4e20
Compare
No description provided.