PB-1124 Add django authentication and permission check to API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msom
force-pushed
the
feat-PB-1124-djang-permissions-in-api
branch
from
b96f59d
to
e73055b
Compare
benschs
approved these changes
Nov 12, 2024
|
No, currently there is no possibility to use JWT or basic auth, as the context of this change is to use django access management to secure service-control in a first step. Once auth is working and authorization is discussed, we'll use the same pattern as in service stac (see PB-1124), hence replacing this (temporary) solution. To use the service, the same authentication as with the admin UI is used ( curl --cookie sessionid=xyz -i http://127.0.0.1:8000/api/users |
msom
force-pushed
the
feat-PB-1124-djang-permissions-in-api
branch
from
e73055b
to
1f8eab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a simple authentication to the API using the django (session) authentication and the django model permission and therefore the same restrictions as in the admin UI.
This PR also gets rid of the ninja test client, as this skips all middleware - probably anyway not a very good idea. Since API tests run slower now, I also added pytest-xdist to be able to test in parallel locally.