Add bandit security checker #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msom
requested review from
schtibe,
benschs,
boecklic,
ltshb,
adk-swisstopo and
asteiner-swisstopo
ltshb
reviewed
Oct 24, 2024
There was a problem hiding this comment.
I've nothing against it, but after a very quick check at the https://bandit.readthedocs.io/en/latest/plugins/index.html some of the issues will already be found by pylint, so I'm not sure it will add a plus.
NOTE: regarding the PR labels you can manually create them when missing, but I've created a draft here https://github.com/geoadmin/infra-terraform-github-bgdi/pull/118 to manage them via terraform
benschs
approved these changes
Nov 5, 2024
schtibe
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously had good experience using bandit for security checks and would suggest to use it here as well (probably best in the pipeline).
What are your thoughts on this @boecklic @schtibe @asteiner-swisstopo @adk-swisstopo @ltshb @benschs (feel free to include more people to the discussion)