Skip to content

[showcase][accordion] Simplify disabled cases by showing minimal markup, and other improvements... #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[showcase][accordion] Simplify disabled cases by showing minimal markup, and other improvements... #515

wants to merge 8 commits into from

Conversation

bsastregx
Copy link
Collaborator

@bsastregx bsastregx commented Mar 18, 2025 •
edited
Loading

Changes in this PR:

Showcase

  • Fix "Filled Header" spacing body classes
  • Use “Customizations” instead of “Common Use Cases” for this section title
  • Provide a more realistic example for the "Custom header (4.1)" case.
  • Explain how to maintain the caption with the same style in the "Custom header (4.1)" case.
  • Simplify disabled cases, by displaying minimal markup

@bsastregx bsastregx added mercury Changes related to Mercury design system showcase Work related to improving the showcase of the design systems labels Mar 18, 2025
@bsastregx
Copy link
Collaborator Author

bsastregx commented Mar 18, 2025 •
edited
Loading

@ncamera one fix and some improvements that @dangmarm asked me to include.

Preview: https://preview-accordion.netlify.app/mercury/components/accordion?hiddenAccordions=Filled,Filled%20With%20Icons,Filled:%20Elevation%201,Filled:%20Elevation%202,Filled:%20Elevation%203,Filled%20Header,Filled%20Header%20With%20Icons,Filled%20Header:%20Elevation%201,Filled%20Header:%20Elevation%202,Filled%20Header:%20Elevation%203,Outlined,Outlined%20With%20Icons,Outlined:%20Elevation%201,Outlined:%20Elevation%202,Outlined:%20Elevation%203

@bsastregx bsastregx requested a review from ncamera April 3, 2025 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncamera ncamera Awaiting requested review from ncamera

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
mercury Changes related to Mercury design system showcase Work related to improving the showcase of the design systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bsastregx @ncamera