[mercury][button] Update "destructive" colors, Include "success" primary button, and Include "icon only" primary and secondary buttons.
#480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upadte error tokens: the values were outdated - Add error tokens: 700 to 1000 variants were missing
Pass colors as parameters to allow the mixin being used with different colors.
- Add `secondary-with-icon` and `secondary-icon-only` button types
…iate icon src metadata
bsastregx
changed the title
[mercury][button] Update "destructive" colors, Include "success" primery button, Include "loading" primaery and secondary buttons, Include "icon only" primary and secondary buttons.[mercury][button] Update "destructive" colors, Include "success" primary button, Include "loading" primaery and secondary buttons, Include "icon only" primary and secondary buttons.
bsastregx
changed the title
[mercury][button] Update "destructive" colors, Include "success" primary button, Include "loading" primaery and secondary buttons, Include "icon only" primary and secondary buttons.[mercury][button] Update "destructive" colors, Include "success" primary button, Include "loading" primary and secondary buttons, Include "icon only" primary and secondary buttons.
bsastregx
added
mercury
|
@ncamera here you can see the showcase for the button: https://preview-showcase-button.netlify.app/mercury/components/button |
ncamera
requested changes
Mar 5, 2025
bsastregx
changed the title
[mercury][button] Update "destructive" colors, Include "success" primary button, Include "loading" primary and secondary buttons, Include "icon only" primary and secondary buttons.[mercury][button] Update "destructive" colors, Include "success" primary button, and Include "icon only" primary and secondary buttons.
|
@ncamera I have commented all the buttons with loaders, since it is not clear yet how they should be implemented, and we also may need the ch-progress. |
ncamera
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR:
✨ New button styles have been added:
button-primary-successbutton-primary-success button-icon-and-textbutton-primary button-icon-onlybutton-secondary-destructivebutton-secondary-destructive button-icon-and-textbutton-secondary button-icon-only