Make Xtext validators resilient #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because: - internal errors may crash source file validation without any error being log (#149) How: - actually catch exceptions & log them through the Activator Signed-off-by: Emmanuel Chebbi <[email protected]>
Because: - unexpected exceptions in a validator were stopping the whole validation (#149) How: - SafeValidator can be used to decorate IValidator and make their validation methods exception-proof - the possible absence of ExtendedClass::baseClass has been taken into account and is less likely to cause errors Signed-off-by: Emmanuel Chebbi <[email protected]>
|
Looks good. Attempting to open an enumeration still raise errors (see #154) but at least they are now logged. We'll decide later how to address/improve this. |
echebbi
added a commit
that referenced
this pull request
Jun 27, 2020
Because: - internal errors may crash source file validation without any error being log (#149) How: - actually catch exceptions & log them through the Activator Signed-off-by: Emmanuel Chebbi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #149.
The CI pass and everything looks good to me. I'll make a last check on GEMOC Studio then proceed to merge the PR.
Changes
SafeValidatorwhich ensures that exceptions thrown by validation methods are caught, logged then discard to continue the validationExtendedClass::getBaseClassreturns has been handled and shouldn't cause errors anymoreAleValidatorwill catch it and log it