Add auth extension handling #586
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Fantix King <[email protected]>
3 tasks
fantix
commented
Mar 6, 2025
Comment on lines
+323
to
+330
| verify_response = await self._http_request( | ||
| "POST", | ||
| "/verify", | ||
| json={ | ||
| "verification_token": verification_token, | ||
| "provider": self.provider, | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Is it expected that the verification will proceed (even successfully) with or without a valid PKCE verifier?
There was a problem hiding this comment.
Yes, that's right. PKCE just protects the actual auth token exchange, so you can verify an email from any user agent, but you will not be able to then parlay that into an authentication unless you have the PKCE verifier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
gel.authmodule as the general binding of the Gel auth extension.