-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Change to nginx-unprivileged image for better kubernetes support #1922
base: master
Are you sure you want to change the base?
[Feature] Change to nginx-unprivileged image for better kubernetes support #1922
Conversation
Originally encountered a problem with the ChromeDriver version that's been addressed in d3adfc7 , expand to show the context if needed.UI Test fails with the error below. Seems a lot of pull-requests are facing the same issue.
|
Have these tests been fixed? |
8fdc311
to
32dda5b
Compare
Seem to work now after rebasing. Looks like this commit addressed the issue -> d3adfc7 |
You might want to change the docker commandline in the readme so it shows forwarding to the new default ports of docker run -it -p 8080:8080 cyberchef and docker run -it -p 8080:8080 ghcr.io/gchq/cyberchef:latest As per: https://hub.docker.com/r/nginxinc/nginx-unprivileged |
Hey, thanks so much for the PR. This will need to be linked to a major bump, due to the changing default port. I see no problems with the current implementation though. |
Solves #1880
Not sure which image-repo you prefer to use, it's using Docker Hub in the pull-request (should be fine since its from a "Verified Publisher" and thus does not count towards the rate limit).
Alternative sources can be found here
Amazon ECR - https://gallery.ecr.aws/nginx/nginx-unprivileged
Docker Hub - https://hub.docker.com/r/nginxinc/nginx-unprivileged
GitHub Container Registry - https://github.com/nginxinc/docker-nginx-unprivileged/pkgs/container/nginx-unprivileged
Quay - https://quay.io/repository/nginx/nginx-unprivileged