Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablify and fix MBC3 inconsistencies. #587

Merged
merged 1 commit into from
Mar 14, 2025
Merged

Tablify and fix MBC3 inconsistencies. #587

merged 1 commit into from
Mar 14, 2025

Conversation

elp2
Copy link
Contributor

@elp2 elp2 commented Feb 27, 2025

Does it make sense to list A000-BFFF as a RW Register and Memory range? I think it makes sense to just remove A000-BFFF from the registers section since the description just copies what is above.

@ISSOtm
Copy link
Member

ISSOtm commented Feb 27, 2025

Paging @Rangi42, I think the Pokémon hackers can confirm whether MBC3 (not MBC30!) can have 8 SRAM banks?

@Rangi42
Copy link
Contributor

Rangi42 commented Feb 27, 2025

MBC3 = 4 SRAM banks and 128 ROM banks; MBC30 = 8 SRAM banks and 256 ROM banks (although JP Pokémon Crystal only used 8 SRAM banks and 128 ROM banks).

Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The maximum number of RAM banks needs to be explained somehow... but that also involves talking about MBC3 versus MBC30. Is that variant already mentioned somewhere?

@elp2
Copy link
Contributor Author

elp2 commented Mar 9, 2025

How would you like me to mention? I would assume that since we can address the 8 banks of RAM as mentioned 00-07 this is already covered that that max is 8 for the MBC3x series? Can add a line to that extent if you want.

@avivace
Copy link
Member

avivace commented Mar 14, 2025

Alright, I'm going to start merging what we have. Feel free to bring this up again in an issue @ISSOtm .

@elp2 thanks for the contribution!

@avivace avivace merged commit 215cae0 into gbdev:master Mar 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants