-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch up SGB packet documentation #537
Conversation
Turn the diagram into a SVG, and reformat/improve the doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think shouldn't, check for example how https://gbdev.io/pandocs/Rendering.html#ppu-modes behaves, there is a limit on how "big it can become" while being free to get as small as possible preserving the layout when seen from smaller viewports.. |
Yep, I would say that should fix it |
Then you can try playing with the proportions by adjusting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, merging this in the current state as I don't have bandwidth for the suggested style changes, I'll come back at them later
Turn the diagram into a SVG, and reformat/improve the doc.