-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update requirements.txt file for changes in #452 #530
Update requirements.txt file for changes in #452 #530
Conversation
Alright, I have edited the OP to replicate the original PR's. That means what's left is only mdBook "wiring up", which falls under my responsibility... so I'll have to do that then. :P Thank you @glinesbdev! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing, @glinesbdev . Putting some sense into what I wrote and making this modular will be super useful also when not generating graphs but when we'll want to make other svgs "theme-able". Thanks a lot!
I'm trying the command line usage but when I run:
python graph_render.py MBC5_Rumble_Mild.csv "MBC5_Rumble_Mild"
The svg is printed out in the stdout and then two svg are actually generate, a "test.svg" and an "output.svg"..
Is this expected?
And also use the newly-generated graphs in the MBC5 page
I finally found some time to hook up this PR's Python to a mdBook preproc. It has to be a preproc, not a renderer/backend, because the files are I used a separate script for the preproc, so that Also, the generated files cannot go under |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @glinesbdev! My apologies for taking this long to do the mdBook part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work. Thanks for cleaning up my initial work and hooking it up @glinesbdev and @ISSOtm !
Supersedes and closes #452
Original OP follows:
It may seem a bit convoluted, but it works:
8mb.video-WRi-EDN02djp.mp4
Some more stuff is needed to merge this but we should be already at a pretty good point:
renderer
to thepreproc
step of mdbook, otherwise the output SVG files cannot be inline injectedFixes #322